Skip to content

Final updates of develop from release 1.9.3#1790

Merged
climbfuji merged 5 commits intoJCSDA:developfrom
climbfuji:feature/final_update_from_rel193
Oct 8, 2025
Merged

Final updates of develop from release 1.9.3#1790
climbfuji merged 5 commits intoJCSDA:developfrom
climbfuji:feature/final_update_from_rel193

Conversation

@climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 6, 2025 •
edited
Loading

Description

Final round of updates from release 1.9.3 (branch release/1.9.0) for develop. An attempt will be made to pull these updatesinto the new feature/update_to_spack_v1 branch for changes that are not related to site configs, and for site configs that haven't been updated yet to work with spack v1. This will be a follow-up PR titled "Update feature/update_to_spack_v1 from develop".

Dependencies

Issues addressed

Closes #1694
Closes #1760

Applications affected

None (all changes already deployed as part of spack-stack-1.9.3)

Systems affected

None (all changes already deployed as part of spack-stack-1.9.3)

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • ...

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation on readthedocs are included in this PR
    • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
  • All necessary updates to the spack-stack wiki will be made when this PR is merged deferred

@climbfuji climbfuji mentioned this pull request Oct 6, 2025
Merged
@climbfuji climbfuji marked this pull request as ready for review October 6, 2025 14:06
@climbfuji climbfuji self-assigned this Oct 6, 2025
rickgrubin-noaa
rickgrubin-noaa reviewed Oct 6, 2025
View reviewed changes
configs/common/packages.yaml
wgrib2:
require:
- '@3.6.0'
- '+ipolates +netcdf'
Copy link
Collaborator

@rickgrubin-noaa rickgrubin-noaa Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While building wgrib2 this way "works" (see: JCSDA/spack#561), wgrib2/package.py ought to be properly fixed.

Copy link
Collaborator Author

@climbfuji climbfuji Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, see the CI failure: https://github.com/JCSDA/spack-stack/actions/runs/18286538992/job/52062910954

@AlexanderRichert-NOAA @rickgrubin-noaa What is the permanent fix? Will that be made for spack-packages only i.e. do we bring over the temporary fix from the spack submodule release/1.9.0 branch for the time being?

Copy link
Collaborator Author

@climbfuji climbfuji Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickgrubin-noaa I've decided to pull in your temporary fix for the reasons stated in JCSDA/spack#568. I assume this hasn't been fixed yet in the new spack-packages repo?

Copy link
Collaborator

@rickgrubin-noaa rickgrubin-noaa Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickgrubin-noaa I've decided to pull in your temporary fix for the reasons stated in JCSDA/spack#568. I assume this hasn't been fixed yet in the new spack-packages repo?

This has not been fixed in the new spack-packages repo.

As far as I can tell (and @AlexanderRichert-NOAA certainly understand better than I), the temporary fix implemented for v3.6.0 isn't necessarily applicable for other, earlier versions. I have not looked into it further.

@climbfuji climbfuji mentioned this pull request Oct 7, 2025
Merged
climbfuji added a commit to JCSDA/spack that referenced this pull request Oct 8, 2025
@climbfuji
Merge pull request #568 from climbfuji/bugfix/wgrib2_netcdf_temp_fix_…
cce215c 
…from_rel193

Cherry-picking 30eb08b from release/1.9.0 for develop to fix the CI build errors discussed in JCSDA/spack-stack#1790 (comment). This is the same as PR #561 that went into release/1.9.0, but updated to match the correct wgrib2 versions.
@climbfuji climbfuji enabled auto-merge (squash) October 8, 2025 20:09
@climbfuji climbfuji mentioned this pull request Oct 8, 2025
Closed
55 tasks
@climbfuji climbfuji disabled auto-merge October 8, 2025 21:35
@climbfuji climbfuji merged commit 14afde6 into JCSDA:develop Oct 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickgrubin-noaa rickgrubin-noaa rickgrubin-noaa approved these changes

@mathomp4 mathomp4 mathomp4 approved these changes

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA

@AlexanderRichert-NOAA AlexanderRichert-NOAA Awaiting requested review from AlexanderRichert-NOAA

Assignees

@climbfuji climbfuji

Labels

None yet

Projects

No open projects
spack-stack-1.9.x (2024 Q4 - 2025 Q3)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

release/1.9.3 tasks When spack-stack-1.9.x is final, update develop with any changes that are missing

3 participants

@climbfuji @mathomp4 @rickgrubin-noaa